Add timeout parameter to run_in_thread function#5213
Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
Add timeout parameter to run_in_thread function#5213devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Alek Petuskey <alek@pynecone.io>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
CodSpeed Performance ReportMerging #5213 will improve performances by 5.31%Comparing Summary
Benchmarks breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timeout parameter to run_in_thread function
This PR adds a new
timeoutparameter to therun_in_threadfunction, which allows setting a maximum execution time for the thread. After the specified timeout is exceeded, anasyncio.TimeoutErroris raised.Changes
timeoutparameter torun_in_threadasyncio.wait_forfor handling timeoutsTesting
Link to Devin run: https://app.devin.ai/sessions/808e952e52174d8c9f2f26ac94c239bc
Requested by: Alek Petuskey (alek@reflex.dev)